search

OrebroUniversity / hiqp

GNU General Public License v3.0
9 stars 2 forks source link

Return result with services #26

Closed ksatyaki closed 7 years ago

ksatyaki commented 7 years ago

Return proper result for all service calls. For example, list_all_primitives should return a vector of strings.

At the moment, there are no return values (except a success, which IMHO has no meaning here) for the service calls.

ksatyaki commented 7 years ago

One thing I immediately see is that, the GeometricPrimitive abstract class should also include a virtual std::vector <float> getParameters() = 0 interface to be able to return the primitive's parameters as a vector. This can then be returned by the TaskManager's getAllPrimitives() function (will be defined).

It also seems reasonable to choose a single std::vector <float> getColor() member instead of getRedComponent(), etc. in the GeometricPrimitive base class.

neckutrek commented 7 years ago

Yes.

Le 1 févr. 2017 15:38, "Chittaranjan Srinivas Swaminathan" < notifications@github.com> a écrit :

One thing I immediately see is that, the GeometricPrimitive abstract class should also include a virtual std::vector getParameters() = 0 interface to be able to return the primitive's parameters as a vector. This can then be returned by the TaskManager's getAllPrimitives() function (will be defined).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OrebroUniversity/hiqp/issues/26#issuecomment-276673225, or mute the thread https://github.com/notifications/unsubscribe-auth/ADmjhazfQFKqi-WicnNyDhDmd6qYNEWvks5rYJjogaJpZM4Luz9k .

ksatyaki commented 7 years ago

Merged into devel-chitt. Awaiting merge into devel.