search

OregSamSas / vardle

worldle based geography quiz game with the counties of the old Hungarian Kingdom
https://oregsamsas.github.io/vardle/
MIT License
1 stars 0 forks source link

Hide shapes of territories for 2nd and 3rd rounds as well #5

Closed OregSamSas closed 2 months ago

OregSamSas commented 2 months ago

Idea

Although, rotation of territory images works fine on 3rd round, because the too specific storing method of the information that whether the 'show-image-button' was pressed, hiding the image doesn't take any effect there. And on the 2nd round, where neighbouring territories are to be guessed, it should be implemented that those neighbouring territories also hide, if that checkbox is checked in the settings.

Bugs

OregSamSas commented 2 months ago

Something is wrong, if both the rotation is checked and the hiding.

OregSamSas commented 2 months ago

Something is wrong, if both the rotation is checked and the hiding.

Oh, because hide rotation is also a button, so it won't place the show-map-button. It's because the safety check here:

    if (getIndexByProperty(image.childNodes, undefined, "button") < 0) { // if the button is not already there