search

OregonDigital / OD2

Next generation of Oregon Digital ( https://oregondigital.org ) digital collections platform, built on Samvera Hyrax ( https://github.com/samvera/hyrax/ )
19 stars 1 forks source link

DeepIndexingService #2287

Closed lsat12357 closed 2 years ago

lsat12357 commented 2 years ago

Descriptive summary

This is to address 2 probs with OregonDigital::DeepIndexingService and potentially suggest an additional change.

  1. fetch_with_persistence is not called if the value is a location. Although the location label is properly fetched and inserted into the solr doc when FetchGraphWorker runs, if item.update_index runs for some reason after FGW, the location label will disappear.
  2. We should also override fetch_value in order to change the message "Fetching #{value.rdf_subject} from the authorative source. (this is slow)" because this is not always true, and it is the same message that the Triplestore uses, so it's additionally confusing.
  3. As noted above, if item.update_index occurs after any/all events that would cause FetchGraphWorker to run, the combined labels inserted by FetchGraphWorker are wiped out. One potential solution would be to extract the combined label assembly that the FGW does, and have it run as part of the DeepIndexingService.
lsat12357 commented 2 years ago

it looks like CreateDerivativesJob does file_set.parent.update_index, in order to add the thumbnail info