search

OregonStateUniversity / fs-ops-normal

Forest Service initial attack hose & equipment estimator for wildland fires.
3 stars 1 forks source link

EstimateTest: Revise defaultFoam test, refactor method if appropriate #275

Closed ybakos closed 1 year ago

ybakos commented 1 year ago

The test suite lacks a group for the defaultFoam and each test is verbose, and has inappropriate title. The implementation has unnecessary logic, and misses the case when structures == 40, which is a bug.

Group and refactor the tests, and refactor the method if appropriate.

ybakos commented 1 year ago

See https://github.com/osu-cascades/fs-ops-normal/commit/fe306e55e1f8131343e79e7fdb327e858cbb535f for inspiration.