Closed GoogleCodeExporter closed 9 years ago
r515 disables Neon version.
./libyuv_unittest --gtest_filter=*Shade
Note: Google Test filter = *Shade
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from libyuvTest
[ RUN ] libyuvTest.TestShade
[ OK ] libyuvTest.TestShade (1 ms)
[----------] 1 test from libyuvTest (1 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3 ms total)
[ PASSED ] 1 test.
Original comment by fbarch...@google.com
on 12 Dec 2012 at 1:50
fixed in r516. alpha used wrong index.
Original comment by fbarch...@chromium.org
on 12 Dec 2012 at 10:31
r518 has vzip instead of vtrn for a little simpler duplicating of values in
order.
Consider doing same to get values bit replicated instead of zero extended, so
results will match x86 closer. The unittest matches exactly for the values it
uses now, though.
Original comment by fbarch...@chromium.org
on 13 Dec 2012 at 1:18
Due to doubling, the neon version is 15 bit accurate at most, so it can't be
made 100% identical to current SSSE3 version. Both could be crippled to 8 bit
accurate but that produces off by 1 for opaque and is slower - requires a shift.
So marking as fixed as the accuracy matches on the important values, and passes
unittest with exact match.
Original comment by fbarch...@google.com
on 18 Dec 2012 at 11:54
Original issue reported on code.google.com by
fbarch...@chromium.org
on 11 Dec 2012 at 11:16