Closed OwnerCM closed 1 year ago
❌ Merging this PR will decrease code quality in the affected files by 3.32%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 4.10 ⭐ | 5.58 ⭐ | 1.48 👎 |
Method Length | 66.88 🙂 | 71.25 🙂 | 4.37 👎 |
Working memory | 10.09 😞 | 10.38 😞 | 0.29 👎 |
Quality | 61.69% 🙂 | 58.37% 🙂 | -3.32% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 121 | 130 | 9 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
ck_mimotion.py | 61.69% 🙂 | 58.37% 🙂 | -3.32% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
ck_mimotion.py | MiMotion.main | 10 🙂 | 253 ⛔ | 15 😞 | 37.54% 😞 | Try splitting into smaller methods. Extract out complex expressions |
ck_mimotion.py | MiMotion.login | 3 ⭐ | 165 😞 | 8 🙂 | 62.68% 🙂 | Try splitting into smaller methods |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
小米运动兼容手机和邮箱账户刷步数,为尽量减少改动文件,未修改配置参数名