[HM5] Cameras - Githubissues

mike-koch commented 5 years ago

This should get the ball rolling regarding tracking security cameras. This should support:

Changing "Caught on Camera" to "Yes" when being spotted by a camera
Changing "Caught on Camera" to "No" when destroying a camera recorder
Changing "Spotted" to "Yes" if the camera detects you performing an illegal action
- This change adds the "Witnesses" to the "Spotted" category. I don't think this will have any unintended consequences; however I wanted to mention it just in case.

It does seem that GitHub is having a field day with marking the entire file as different, so I'll try to see what's up with that and try to get rid of it. Going to https://github.com/OrfeasZ/Statman/pull/10/files?utf8=✓&diff=unified&w=1 should remove the whitespace-only changes.

OrfeasZ commented 5 years ago

The entire files are marked as different probably because of your line ending settings (if you're on Windows Git is configured to convert line endings to LF on check-in). You can change that by adjusting the core.autocrlf setting and then changing back the line endings for the files you modified to CRLF.

OrfeasZ commented 5 years ago

In regards to the other changes, I would suggest decoupling the witnesses event from the spotted event. If it's something you want to track it should be added separately, with a list of active witnesses maintained (similarly to how spotters are tracked).

As for the camera events, were you able to get the initial SecuritySystemRecorder spotted event consistently? In my testing it sometimes wouldn't trigger for the first camera in the level, even though the in-game indicator would show up. I'll also add add some more specific comments to the code.

mike-koch commented 5 years ago

Line endings have been fixed (I ended up force pushing the branch to make sure everything got committed / pushed correctly; it shouldn't cause any issues with the merge). I also condensed / cleaned up the one if condition you mentioned.

I would suggest decoupling the witnesses event from the spotted event. If it's something you want to track it should be added separately, with a list of active witnesses maintained (similarly to how spotters are tracked).

I have separated the witnesses event from the spotted event, so they're being tracked separately now. However, I did keep the "Spotted" condition for the UI to be 0 spotters and 0 witnesses (to match how the game's end screen works). If you want them separate on the UI, let me know.

As for the camera events, were you able to get the initial SecuritySystemRecorder spotted event consistently? In my testing it sometimes wouldn't trigger for the first camera in the level, even though the in-game indicator would show up. I'll also add add some more specific comments to the code.

I have not encountered any issues where the first camera does not trigger the spotted event yet. Is there a particular camera that seems to have this issue?

OrfeasZ commented 5 years ago

I was testing on showstopper, camera at the second floor next to the fireworks panel. Default starting location and disguise.

I'll take a look at the code tomorrow and let you know if there's anything else I think needs addressing.

Thanks for this!

mike-koch commented 5 years ago

Ooops... I guess I accidentally closed this when making some branch changes on my fork 😳 ..... I'll open a new one with the latest changes.

OrfeasZ / Statman

[HM5] Cameras #10