search

Organizr / docker-organizr

Docker image for Organizr
GNU General Public License v3.0
96 stars 12 forks source link

Make nginx listen on both address families #21

Closed starcraft66 closed 3 years ago

starcraft66 commented 3 years ago

I noticed organizr wasn't accessible over IPv6 so this should fix it.

Roxedus commented 3 years ago

I am not too keen on adding this. I deliberately set this to IPV4 only, based on feedback from other, similar images(people disabling ipv6 on kernel level etc.).

starcraft66 commented 3 years ago

based on feedback from other, similar images(people disabling ipv6 on kernel level etc.).

While that is unfortunate, I propose that we should use the same mechanism that the official nginx docker image uses to determine whether or not to listen on IPv6 (https://github.com/nginxinc/docker-nginx/blob/master/entrypoint/10-listen-on-ipv6-by-default.sh) the checksum verification part would need to be altered but it would mostly be a drop-in addition to the container init scripts.

This would allow people who chose to blacklist the ipv6 kernel module to use nginx with ipv4 only and allow people with ipv6 enabled to use Organizr over ipv6.

Organizr shouldn't be dictating users about their infrastructure setup. Furthermore, applications still not supporting/disabling ipv6 in 2021 (when they are fully capable of ising it!) hinders ipv6 adoption.

Roxedus commented 3 years ago

Organizr shouldn't be dictating users about their infrastructure setup.

This is not the goal, ultimately it's to ease support for us.

Here are some related issues that lead to the decision: https://github.com/linuxserver/docker-letsencrypt/pull/242 https://github.com/linuxserver/docker-swag/issues/92

I just can't cater to everyone. However, if you do want to PR a adoption of the init script from the official container, that would be very much appreciated.