search

OriAmir / React-Responsive-Gallery

Simple and responsive gallery for react
45 stars 5 forks source link

Enable Video Support #20

Closed howdyhyber closed 11 months ago

howdyhyber commented 2 years ago

Is it possible to add a video view support for this library?

OriAmir commented 2 years ago

hi @howdyhyber, It's a good idea to add video support to the library, I may try to test adding that to the library in the near future. You are welcome also to create PR with that if it's interesting you.

Thanks!

suntong commented 1 year ago

Looking for the same thing; hope it'll be supported someday...

suntong commented 1 year ago

Online preview might be difficult, but show in list and offer to download might be an easier start, which will be more than good enough...

OriAmir commented 1 year ago

Online preview might be difficult, but show in list and offer to download might be an easier start, which will be more than good enough...

Hi @suntong , can you pls explain more detailed your idea? You mean just adding symbol of video and download without video actually playing ?

suntong commented 1 year ago

Yeah, that will be more than good enough for me.

Normally, for an event, or trip, we not only take pictures but short videos as well. I'm just hoping to find a ready-made package that can support both pictures and videos, together, not separately. The rest are all design details, bare-minimum is to be able to show it in the list and provide a way for people to download. If we need to provide a picture for the video ourselves, that's fine too.

And further FYI, after that comment I did some further research and found that online viewing/preview seems to be not too difficult, based on this file

https://github.com/harryyizihan/around_web/blob/f882f4aeee4cd865db2f37272fed9de44057ae7b/src/components/Home.js#L112

and this Demo video: https://youtu.be/tXMTwyzDsZk

But this is only me judging from the surface...

Just hope that videos'll be supported someday, in any form or shape...

OriAmir commented 1 year ago

@suntong thanks, sounds like something I will try soon and update. i open to PR as well!

suntong commented 1 year ago

Thanks. I'm not a JS/TS/front-end developer at all, :)

OriAmir commented 1 year ago

Thanks. I'm not a JS/TS/front-end developer at all, :)

Ahah got it. Anyway if you could star ⭐️ the project it's will be great. Thanks and will update soon.

OriAmir commented 11 months ago

Done in v4

suntong commented 11 months ago

Bravo!!! 👏👏👏🎉🎉🎉