Magic Effects Improvements

[OrianaVenture]

Current known bugs and improvements for the magic effects system:

• Triple Shot is unbalanced. Making the additional projectiles deal less damage may fix this.
• The following need to be reviewed to ensure appropriate effects are applied. Remove any that do not work. Add those that do.
  • Fishing Rod
  • Staves and Magic Weapons
  • Tools
• Free Build may unlock some items before they should be available.
• Throw enchantment does not apply all other magic effects to the projectile.
• AEPI extra slots are not checked for applying effects. Need to add support with the API.

[jneb802]

Bugs

• When using the attack speed magic effect on weapons, sometimes the user will receive extreme increases to attack speed. Overall, attack speed enchants are inconsistent.
• When players feint is greater than 100%, poison damage from CLLC monsters will still kill the player.
• When player augments off a +% durability enchant, the durability stays at the higher number. Example, item with +X% durability enchant has 200 / 200 durability. Player augments off the durability enchant. Item now has 200 / 100 durability.

Suggested improvements

• Remove the "parry force" (ModifyParry_ItemData_GetDeflectionForce_Patch) section from the +Parry % magic effect. Consider making a new magic effect specifically for increase parry force. Increase block armor via parry bonus and increasing the parry force are distinct considerations for character building and shouldn't be grouped into one effect.
• Config option to disable the jumping sound from Air Jump enchant
• Consider adding additional projectile deal less damage to double magic shot as well.

[OrianaVenture]

There was an attack speed issue present pre-0.9.38, there was a small patch to that system that should have helped a bit. It's likely you are seeing a side effect of the vanilla bug where attack speeds can speed up and skip animations. I'm not sure how to fix that, nor what the cause would be if it isn't in the core game issue I'm thinking of.

[OrianaVenture]

More changes:

• Prevent the recall enchantment from applying to objects that cannot be thrown.
• Prevent multiple of the same enchantment from being chosen when augmenting (might pull this into a separate issue)

[Jester2020]

I'm not a huge fan of Tripple Shot. It seems like sometimes it doesn't work, or simply hard to tell when it does, conflicts with other mods/items at times that also have projectile increasing features (which i've either removed or gotten other devs to compensate for). As an alternative something like "Power Shot" with a damage multiplier to be determined by your balancing decisions and potentially a bigger knockback increase and a cool magicial effect on the arrows and/or bow when it fires.

[jneb802]

I'm in the process of making my own balance patch and noticing some things. Most damage effects follow this tiering:

      "ValuesPerRarity" : {
        "Magic" : { "MinValue" : 10, "MaxValue" : 20, "Increment" : 1 },
        "Rare" : { "MinValue" : 10, "MaxValue" : 20, "Increment" : 1 },
        "Epic" : { "MinValue" : 10, "MaxValue" : 20, "Increment" : 1 },
        "Legendary" : { "MinValue" : 15, "MaxValue" : 25, "Increment" : 1 }
      },

However, this means the only benefit to rolling higher level gear is to get more affixes on the item. I think the effects should be different for each tier like this:

      "Value": {
        "Magic" : { "MinValue" : 5, "MaxValue" : 10, "Increment" : 1 },
        "Rare" : { "MinValue" : 10, "MaxValue" : 15, "Increment" : 1 },
        "Epic" : { "MinValue" : 15, "MaxValue" : 25, "Increment" : 1 },
        "Legendary" : { "MinValue" : 25, "MaxValue" : 35, "Increment" : 1 }
       }

[OrianaVenture]

Many of these issues have been fixed in #5 but some still remain.

[OrianaVenture]

Need to add Unarmed Skill magic effect to applicable items with that skill.

[OrianaVenture]

Investigate glowing effect and see if it can be applied to all object types. Reported to not work with LoxCape and some weapons.

[OrianaVenture]

Multishot code should remove item type and skill checks and should be controlled by mod configurations. (done)

[OrianaVenture]

Look into attack speed animation bug on multiple logout/login in one game session.