search

OrianaVenture / VentureValheim

Mods for Valheim
MIT License
4 stars 4 forks source link

conflict between Logout Tweaks and Speedy Paths #36

Closed nbusseneau closed 1 month ago

nbusseneau commented 2 months ago

Hey,

Noticed there's a conflict between Logout Tweaks and Speedy Paths: if you logout while the Speedy Paths buff is active (e.g. while standing on wood or stone), on login the Speedy Paths buff appears twice, with one of the buffs doing nothing but staying permanently, even if you walk away from wood / stone.

nbusseneau commented 2 months ago

I had a quick look at the code and I'm not sure why the buff is not ignored by Logout Tweaks though :/

OrianaVenture commented 2 months ago

I thought I had fixed the incompatibility in the 0.5.0 update. What version of the mods and game are you using?

nbusseneau commented 2 months ago

Yeah, from looking at the code added in 0.5.0 it makes no sense to me either why the status effect is picked up... Haven't investigated further.

Versions:

OrianaVenture commented 2 months ago

Oh, I remember now. I couldn't fix that because the status effects from Speedy Paths aren't mimicking vanilla behavior and are added when Hud.instance.UpdateStatusEffects is called here Speedy Paths Repo. Which my mod calls here Logout Tweaks Repo. I might be able to remove that line if the status effects are updating properly without it. Otherwise I have my own version of that mod called Need For Speed you can use in its place until it can be fixed.

nbusseneau commented 2 months ago

Good catch! Yeah it looks like UpdateStatusEffects is called in the main Update loop so I suspect it should be fine even without a manual call at load time.

Did see Need for Speed but I liked the Speedy Paths approach with a visible status effect better, makes it obvious to the user when a buff or debuff is applied 😅

OrianaVenture commented 1 month ago

This is fixed in version 0.5.1

nbusseneau commented 1 month ago

Thanks!