OrianaVenture / VentureValheim

Mods for Valheim
MIT License
4 stars 4 forks source link

Logout Tweaks: Timer issue on potions #37

Closed KidSith closed 3 weeks ago

KidSith commented 1 month ago

I had 38 seconds left on my frost resist when I decided to log off, now everytime I pop a frost resist it only goes up to 38 seconds

buck2202 commented 1 month ago

I think this is an issue for rested as well. It seems to go to the time at log-in rather than the correct rested time for the comfort level. I logged in with 15 minutes, and when I rested at comfort 2, got 15 minutes again.

OrianaVenture commented 1 month ago

I have not been able to reproduce this issue. I suspect there may be a mod conflict. If both of you can share your mod lists that would be helpful.

buck2202 commented 1 month ago

just

BetterUI_ForeverMaintained-BetterUI_ForeverMaintained-2.5.6
Azumatt-AzuClock-1.0.3
Azumatt-Recycle_N_Reclaim-1.3.4
JereKuusela-Server_devcommands-1.81.0
VentureValheim-Venture_Logout_Tweaks-0.5.1
Advize-PlantEasily-1.8.0

for me

I tried to reproduce it again last night after my comment and it did not happen again, might not be a 100% thing. Will try to run with the log open and see if there are any hints in there if it happens again

nbusseneau commented 3 weeks ago

I have had this happening to others and myself as well, both meads and rested buffs. I haven't found a way to reproduce it consistently yet.

OrianaVenture commented 3 weeks ago

I think this is possible just an issue with version 0.5.1, or it may be a new bug introduced in the last game update. If this does not happen with version 0.5.0 then it may be related to the compatibility changes to make the mod function with SpeedyPaths. If so I will have to revert the compatibility update.

nbusseneau commented 3 weeks ago

I don't actually know, I hadn't set up 0.5.0 in the modpack, we played straight with 0.5.1.

OrianaVenture commented 3 weeks ago

Found the issue. Code is modifying the original status effect rather than a copy, causing the values to be incorrect. Will be pushing out a fix in 0.5.2. Thank you for the reports!

nbusseneau commented 3 weeks ago

Very nice, thanks for the fix!