Origen-SDK / origen

The Origen Semiconductor Developer's Kit core platform
http://origen-sdk.org
MIT License
20 stars 24 forks source link

Enforcing this rule would lead to lots of rework #449

Closed pderouen closed 1 year ago

pderouen commented 1 year ago

Applications generated by Origen with the new structure fail this rule and auto correct breaks applications. Probably best to just turn it off.

chrisnappi commented 1 year ago

LGTM, thanks for looking out.

pderouen commented 1 year ago

Sure thing. That rule rejects this:

class MyAppName::DUT::MyDut < MyAppName::DUT

In favor of something like this (with epic auto-correct failure):

module MyAppName
  module DUT
    class MyDut < MyAppName::DUT
    ...
    end
 end
end
pderouen commented 1 year ago

Shall I merge? It's not urgent, just don't want this to sit too long.

redxeth commented 1 year ago

@pderouen Paul-- were you going to do a new release?