Allow remotes to disable version prefix; git branch comparator corrected

Origen-SDK / origen

The Origen Semiconductor Developer's Kit core platform

http://origen-sdk.org

MIT License

20 stars 24 forks source link

Allow remotes to disable version prefix; git branch comparator corrected #452

Closed CodyBriscoe closed 5 months ago

CodyBriscoe commented 5 months ago

Ran into a scenario where I needed to use a remote from a repo controlled by another team. They tag their repo as '1.2.3' not 'v1.2.3', so this update lets remotes disable that prefixing.

Additionally ran into an error where version == 'HEAD' was using the VersionString#equal? instead of String#equal?, which it would fail because it didnt know how to compare the version of 'HEAD', so I forced the string literal comparison with a .to_s call

CodyBriscoe commented 5 months ago

Not sure what's going on with the regressions, having bundler install issues

pderouen commented 5 months ago

Thanks for the update.

priyavadan commented 5 months ago

@Origen-SDK/core any reviews / suggestions here? Thanks!

priyavadan commented 5 months ago

Got info from @ThaoHuynhFsl that NXP's use cases are good with this update!

priyavadan commented 5 months ago

@redxeth

ThaoHuynhFsl commented 5 months ago

Ran couple of our active apps with this PR and it works fine. No issue from me