search

Origen-SDK / origen_sim

Plugin to enable Origen patterns to be run in a dynamic Verilog simulation
MIT License
1 stars 4 forks source link

Verdi support #17

Closed priyavadan closed 6 years ago

priyavadan commented 6 years ago

@ginty I need some input on how to address the example.rc file template

Other than that, verdi seems to be working well in my test environment now.

priyavadan commented 6 years ago

Just noticed that if the LD_LIBRARY_PATH is not set in the user environment, the fsdb files are not generated.

Will see if I can add code to set the path automatically before the command is run.

ginty commented 6 years ago

Hi @priyavadan, can you rework this implementation to make the Verdi support an option of the Synopsys vendor?

I'm writing the documentation for OrigenSim and it is confusing trying to talk about this when it is organized by vendor and then we have Verdi treated like a vendor when it is really just a different build option for Synopsys.

If might be as simple as just saying verdi: true in the configuration and then implementing the Verdi branches as if config[:verdi] underneath the existing if config[:vendor] == :synopsys branches, rather than treating :verdi like a vendor.

Thanks!

priyavadan commented 6 years ago

@ginty Okay, I will make some updates today! Thanks!

priyavadan commented 6 years ago

@ginty running into some issues, so going to continue debug tomorrow.

when I am done (hopefully tomorrow) :verdi will be available as a configuration option just like dve.

Thanks & Sorry!

ginty commented 6 years ago

@priyavadan, no probs

priyavadan commented 6 years ago

hi @ginty I have updated the PR. Please let me know if any questions or concerns.

priyavadan commented 6 years ago

@ginty okay to merge?

ginty commented 6 years ago

Hi @priyavadan, sorry after looking through this in more detail I think empty.rc should be re-instated.

This is used to create an initial wave config file for the user if non exists yet, it is referenced here: https://github.com/Origen-SDK/origen_sim/blob/master/lib/origen_sim/simulator.rb#L251

And from that we can see that the wave_config_ext method needs to be updated for Verdi - https://github.com/Origen-SDK/origen_sim/blob/master/lib/origen_sim/simulator.rb#L260

Can you also please merge latest master into this branch and setup empty.rc to include the 10 comment registers as described in #24.

So to test this, you should delete (or temporarily move) all per-user wave configs in config/waves. Run a verdi simulation, then execute the command OrigenSim provides to view the waves. We want to see that initial wave view having a debug group that contains the comments and other items in line with the other simulators.

Thanks!

priyavadan commented 6 years ago

@ginty sorry about that, pushed my changes in finally!