search

Origen-SDK / origen_sim

Plugin to enable Origen patterns to be run in a dynamic Verilog simulation
MIT License
1 stars 4 forks source link

Ignore case when matching log lines #21

Closed ginty closed 6 years ago

ginty commented 6 years ago

When writing up the log guide I thought that it might be safer to do these matches case insensitive.

Thoughts?

pderouen commented 6 years ago

I can see it being helpful to have the compares be case insensitive. Are there any cases where you might want to force a case sensitive compare?

coreyeng commented 6 years ago

I could see it either way. Should we also add matching any regex instead of just strings?

ginty commented 6 years ago

Good idea @coreyeng, I was trying to think of a nice way to allow a user to specify that they wanted case sensitivity if they really needed it, supplying their own regex instead of a string seems like a good solution.

ginty commented 6 years ago

OK, added the ability to supply a regexp to the log filters instead of a string.

This means that the match will be case insensitive in the default case where a string is given, but a regexp can be used if case-sensitivity or any other more fine grained control over what is matched is required.