OriginProtocol / dshop

Origin Dshop - launch your own decentralized store
https://www.originprotocol.com/dshop
MIT License
138 stars 87 forks source link

Off-chain changes broke offline payment Accept #547

Closed franckc closed 4 years ago

franckc commented 4 years ago

Before the off-chain changes, if an order was made with the offline payment method, the merchant would have the option to Accept or Reject the order from the admin order details page.

This is currently broken, the payment is immediately marked as Paid after the order is placed.

Here are the payment statuses and actions we should support:

franckc commented 4 years ago

@gullible1 Can you please confirm the payment statuses above make sense for offline payments? Thanks!

gullible1 commented 4 years ago

@franckc yes they make sense! For shops that have integrated Printful and have enabled manual transactions, we should probably make sure that the order is only pushed to Printful after the merchant marks an order as paid.

franckc commented 4 years ago

Thanks @gullible1 - ah yes, great point about making sure the printful order for offline payment only gets processed after the payment gets accepted by the merchant. CC @shahthepro

shahthepro commented 4 years ago

Sure, will make that change. @franckc