search

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge
MIT License
15 stars 7 forks source link

Bridge server crashes when using Python 3.7 #103

Closed franckc closed 5 years ago

franckc commented 6 years ago

There is a change in Python 3.7 compared to prev versions where "async" is now a reserved keyword.

Several libraries the bridge server depends on (celery, kombu, redis) do use that keyword and need to get upgraded to fix this issue.

For now the workaround is for developers to use Python 3.6

tomlinton commented 6 years ago

It looks like celery is the issue here. I think the redis package is OK for 3.7. Confusingly the error that celery spits out is in a file named redis.py.

I tested on 3.7 with an install from the development branch of celery that has the fix for this and the celery worker was fine. It looks like a minor release for celery will happen at the end of the month (i.e. we are waiting for celery 4.2.1).

franckc commented 6 years ago

Thanks for investigating on this @toml - nice work ! Sounds good, let’s upgrade to celery 4.2.1 when it becomes available.

On Tue, Jul 17, 2018 at 1:07 AM Tom Linton notifications@github.com wrote:

It looks like celery is the issue https://github.com/celery/celery/issues/4849 here. I think the redis package is OK for 3.7. Confusingly the error that celery spits out is in a file named redis.py.

I tested on 3.7 with an install from the development branch of celery that has the fix for this and the celery worker was fine. It looks like a minor release for celery will happen at the end of the month (i.e. we are waiting for celery 4.2.1).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OriginProtocol/origin-bridge/issues/103#issuecomment-405496819, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5u9hboYvrkUvwnd0556IVOHfDdGS8lks5uHZsugaJpZM4VOWI5 .

micahalcorn commented 6 years ago

Hey, @tomlinton are you on our Discord channel? If, so what’s your name there? If not, well, join us! 😄

tomlinton commented 6 years ago

toml on discord :smile:

tomlinton commented 6 years ago

celery 4.2.1 is out but this fix didn't make it. :cry:

tomlinton commented 5 years ago

Closed by removal of celery in #134.