Sparrow dom/attestation error handling

[sparrowDom]

Checklist:

• [x] Code contains relevant tests for the problem you are solving
• [x] Code has been formatted with autopep8 --in-place --recursive --a --a .
• [x] Ensure all new and existing tests pass
• [ ] Update any relevant READMEs and docs
• [x] Submit to the develop branch instead of master

Description:

Adding additional error handling to airbnb attestation

[sparrowDom]

@tomlinton can you review this again please?

[tomlinton]

@sparrowDom will test it shortly!

[sparrowDom]

@tomlinton thanks.

I don't have the permission to merge this. Probably @micahalcorn will merge it when he reviews https://github.com/OriginProtocol/origin-dapp/pull/303 that depends on this Pull Request.

[sparrowDom]

@tomlinton I have added 2 commits that change email validation errors to a general error: https://github.com/OriginProtocol/origin-bridge/pull/114/commits/d95b28665df500502b8d5c37c48e3c802d87622e https://github.com/OriginProtocol/origin-bridge/pull/114/commits/c4bbd629e51d70200ed935da23e61b6efde41730

Reason for the first change is that in second stage of email attestation only code field is displayed and email field is not and users wouldn't be able to see the error message tied to email field.

The second was a validation error, and I think a general service error would be more fitting.

Can you check if the changes make sense to you?

[micahalcorn]

I seem to be getting Could not send verification code. Please try again shortly. when I try to call email/generate-code using the same environment variables that worked for me yesterday. SendGrid is showing everything operational on their public status. Is there any way to debug this without checking the logs in our account?

[sparrowDom]

Hey yes, can you check in your development console in browser what bridge server the requests are being issued to, and what is the response?

In my case the request goes to http://localhost:5000/api/attestations/email/generate-code with POST method, and response is an empty object with status code 200:

[sparrowDom]

And on bridge server in environmental variables file .enva variable SENDGRID_API_KEY is set to SG.4....KzKg. Have just tried it this second and it works for me.

[micahalcorn]

Thanks guys, false alarm. I somehow had a rogue character creep into my API key, so it was failing with a 401 under the hood.

@tomlinton, should we at least check the error message here and provide something more meaningful in our EmailVerificationError?

[tomlinton]

@micahalcorn I think we do definitely need a logging implementation in origin-bridge so the errors from SendGrid/other attestation providers are logged on the bridge server (and probably something like Sentry so we get alerts). :thumbsup: That general error is for displaying in origin-dapp because we don't want to be displaying errors about bad API Keys/origin-bridge configuration issues in the dapp.

[micahalcorn]

@tomlinton oh, right, because the key is stored on the bridge server and not passed in from origin-js. Got it, thx. 👌

[sparrowDom]

Yeah logging would be really useful for development debugging and also for keeping track what goes on on staging and production servers.