Update pagination configuration - Githubissues

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge

MIT License

15 stars 7 forks source link

Update pagination configuration #129

Closed sparrowDom closed 6 years ago

sparrowDom commented 6 years ago

Checklist:

[x] Ensure all new and existing tests pass
[x] Submit to the develop branch instead of master

Description:

Listing, Purchase and Review resources when queried by default return 10 items. With maximum number of parameters per page allowed set to 100.

Query parameter to use:

page indicates the pagination page number
results_per_page number of results per page. Defaults to 10, can be between 1 - 100.

Fixes following issues:

micahalcorn commented 6 years ago

@franckc we'll hold off on https://github.com/OriginProtocol/origin-js/issues/264 until Tyler's work is merged, as the resource methods might look completely different.

sparrowDom commented 6 years ago

@micahalcorn can we still merge the bridge server part, or do we wait for this as well?

micahalcorn commented 6 years ago

No, I'll let Franck merge ☑️