search

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge
MIT License
15 stars 7 forks source link

Airbnb attestations don't work with international domains #136

Closed joshfraser closed 5 years ago

joshfraser commented 5 years ago

The current Airbnb attestation service expects the Airbnb domain to be airbnb.com but regional domains like airbnb.co.uk are just as valid.

franckc commented 5 years ago

Ah good catch. @joshfraser is that a p0 ? or can we fix shortly after V1 ?

joshfraser commented 5 years ago

Nah, don't think it's a p0. Just wanted to flag it so we fix it later.

franckc commented 5 years ago

Sounds good. Let's prioritize it for after V1 then...

tomlinton commented 5 years ago

Does this impact the functionality of the attestation though? My understanding was that the international version of the Airbnb domain will serve up the same page but with different localisation settings like language which shouldn't prevent our attestation from working.

sparrowDom commented 5 years ago

@tomlinton yeah you are right. The part that needs some adjustments is probably just the form validation, that will not let any domains other than airbnb.com through.

tomlinton commented 5 years ago

Fixed in #748.