corrects DB params in celery and alembic config

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge

MIT License

15 stars 7 forks source link

corrects DB params in celery and alembic config #25

Closed Gzing closed 6 years ago

Gzing commented 6 years ago

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[x] Submit to the develop branch instead of master

Description:

Corrected the sql database params in celery app settings and in the alembic migration engine.
Cleaned up Celery configurations

tyleryasaka commented 6 years ago

@joshfraser SQLALCHEMY_DATABASE_URI is not an environment variable here. It's being set on the app config, and it is actually being assigned the value of DATABASE_URL. So we just have the one environment variable to worry about in heroku.

https://github.com/OriginProtocol/bridge-server/blob/develop/app/app_config.py#L16

Gzing commented 6 years ago

@tyleryasaka I had already rebased and pushed this branch onto develop and verified the tests passing with the latest pytest command checking the codestyle as well. The issue was with web3 library and it's unpinned dependencies, which was caused and fixed a day ago. pushed another commit on this branch upgrading web3 now.

For future PRs can you use branches on this repo instead of your fork? You should have access to do that now. Makes things easier to review and also allows others to push minor changes. :+1: