Closed Gzing closed 6 years ago
Yay! Thanks for adding this @Gzing.
Are TWITTER_CONSUMER_KEY and TWITTER_CONSUMER_SECRET really required fields?
Some of these fields would probably benefit from having some examples. We should be able to suggest sane defaults for RPC_SERVER, IPFS_DOMAIN and IPFS_PORT.
I removed the PROJECTPATH dependency from the company-website
repo and we can do the same thing here.
Are TWITTER_CONSUMER_KEY and TWITTER_CONSUMER_SECRET really required fields?
real twitter key,secret are not required but the env vars are being imported module level on the code right now, which throws an error if these keys are not present. Didn't change/correct it to limit the scope of changes done in this PR. Will fix and remove the twitter dependencies in another PR.
Some of these fields would probably benefit from having some examples. We should be able to suggest sane defaults for RPC_SERVER, IPFS_DOMAIN and IPFS_PORT.
Sure, I can add those as well. :+1:
I removed the PROJECTPATH dependency from the company-website repo and we can do the same thing here.
Will check and update :+1:
First pull request? Read our guide to contributing
Checklist:
develop
branch instead ofmaster
Description:
Adds heroku one click deploy buttons