Add timeout support to IPFSHelper

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge

MIT License

15 stars 7 forks source link

Add timeout support to IPFSHelper #61

Closed franckc closed 6 years ago

franckc commented 6 years ago

The current IPFHelper utility class does not support specifying a timeout. This can cause the IPFHelper.file_from_hash() function to block indefinitely in case the IPFS back-end does not return data.

We should add support for timeout and update the various call-sites to a) pass a reasonable timeout value (a few seconds) and b) handle possible timeout error exception.

DanielVF commented 6 years ago

We should definitely specify a default timeout here. Perhaps 20 seconds?

franckc commented 6 years ago

We no longer use IPFS in the bridge server. Closing.