OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge
MIT License
15 stars 7 forks source link

AirBnB verification codes can look like phone numbers #96

Closed tyleryasaka closed 6 years ago

tyleryasaka commented 6 years ago

When testing, I got this verification code: 0x3b06524d.

AirBnB wasn't too crazy about it.

screen shot 2018-06-25 at 1 43 27 pm

If possible, we should change the format of our codes so that they will never resemble phone numbers.

joshfraser commented 6 years ago

A list of random English words would be harder for them to detect or block. Something like:

Verifying myself on Origin: candy maple velvet ...

sparrowDom commented 6 years ago

Good idea, tnx.

sparrowDom commented 6 years ago

Verification string now consists of 7 words, as discussed in this thread. How it looks:

screenshot 2018-06-26 15 39 31

The fixes have been pushed to origin-bridge airbnb attestation fix branch and also 1 extra commit has been added to origin-dapp airbnb attestation branch for UI to account for longer verification codes.

micahalcorn commented 6 years ago

Done via #97 ✅