Airbnb attestation fixes - Githubissues

OriginProtocol / origin-bridge

We've moved to a monorepo: https://github.com/OriginProtocol/origin/tree/master/infra/bridge

MIT License

15 stars 7 forks source link

Airbnb attestation fixes #97

Closed sparrowDom closed 6 years ago

sparrowDom commented 6 years ago

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Code has been formatted with autopep8 --in-place --recursive --a --a .
[x] Ensure all new and existing tests pass
[x] Update any relevant READMEs and docs
[x] Submit to the develop branch instead of master

Description:

A fix to already merged Airbnb attestation Pull Request

Funny thing, turns out that claim data field contains only numbers the isValidAttestation origin-js/user.js function fails to verify claim as valid.

Change verification string to a harder to block word mnemonic.

Dependant Pull requests

tyleryasaka commented 6 years ago

@sparrowDom off the top of my head, the cause for the verification to fail with numbers might have something to do with implicit type conversion in javasript. Just a guess.