search

OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
116 stars 80 forks source link

Vault generalisation #1533

Open sparrowDom opened 1 year ago

sparrowDom commented 1 year ago

As part of the OpenZeppelin audit report the OZ team has suggested we could do a better job with Vault generalisation:

Screenshot 2023-05-22 at 15 18 13

I have started a draft PR https://github.com/OriginProtocol/origin-dollar/pull/1519 and came pretty quickly to a realisation that this is not going to be a small task and we also need to be quite cognisant of which contract's external functions get renames and what possible contract / dapp / analytics re-deploys that will trigger.

In the long run it would be still cool we address this issue as to no cause too much technical debt with improper naming.

One thing is sure, that this is not a high priority task and IMHO we should get to it when we have more breathing room.

sparrowDom commented 1 year ago

Low priority would love your thoughts on this one @DanielVF @naddison36 @rafaelugolini @micahalcorn

naddison36 commented 1 year ago

I'm not a fan of changing the contract ABIs once they are deployed. I can do the Vault Natspec changes as part of collateral swaps as that will redeploy the vault contracts.