Deploy 091 - Upgrade OETHVaultCore

[shahthepro]

Contracts

• OETHVaultCore: 0x8f371d8e65f35914cdb8dd58b997411871dabb37

Governance

• Proposal: 78389253671544237322939434422056971914944279457140328550595948923573494383344

• Proposal Tx: 0xf3fa5f5bca75f0dc10e712d8296ef095be14b16d7b67d478c21fad38e4b574f8

  If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

• [ ] Code reviewed by 2 reviewers.
• [ ] Copy & paste code review security checklist below this checklist.
• [ ] Unit tests pass
• [ ] Slither tests pass with no warning
• [ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

[naddison36]

I have verified the following

• The original PR to master only has one approver but I've since review it. https://github.com/OriginProtocol/origin-dollar/pull/1995
• The proposal is upgrading the proxy to the correct implementation address.
• The proposal calls cacheWETHAssetIndex on the Vault
• The OETH Vault proxy address in the proposal is correct
• The deployed OETHVaultCore implementation contract matched the source code on this shah/deploy-091 branch.

sol2uml diff 0x8f371d8e65f35914cdb8dd58b997411871dabb37 .,node_modules
Compared the "OETHVaultCore" contract with address 0x8f371d8e65F35914CDb8Dd58B997411871dABb37 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableERC20Detailed.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultCore.sol
match   contracts/vault/VaultCore.sol
match   contracts/vault/VaultInitializer.sol
match   contracts/vault/VaultStorage.sol

[sparrowDom]

• I've verified that the deployed contract address 0x8f371d8e65f35914cdb8dd58b997411871dabb37 matches the sources in git: npx sol2uml diff 0x8f371d8e65f35914cdb8dd58b997411871dabb37 .,node_modules
• there are 2 proposals created for this deploy, the one with id 78389253671544237322939434422056971914944279457140328550595948923573494383344 should be passed
• the proposal upgrades the OETHVaultCore of the OETHVaultProxy (addresses correct), and calls cacheWETHAssetIndex on the OETHVaultProxy

Source code verification:

npx sol2uml diff 0x8f371d8e65f35914cdb8dd58b997411871dabb37 .,node_modules
Compared the "OETHVaultCore" contract with address 0x8f371d8e65F35914CDb8Dd58B997411871dABb37 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableERC20Detailed.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultCore.sol
match   contracts/vault/VaultCore.sol
match   contracts/vault/VaultInitializer.sol
match   contracts/vault/VaultStorage.sol