OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
112 stars 73 forks source link

OZ - Native Staking - N-06 Unnecessary Conditional #2082

Closed naddison36 closed 1 month ago

naddison36 commented 1 month ago

Contract changes

Issue

The require statement in _doAccounting checks that both _fuseIntervalStart and _fuseIntervalEnd are less than 32 ether and that _fuseIntervalStart < _fuseIntervalEnd. However, the _fuseIntervalStart < 32 ether condition is redundant as this condition is already ensured by the two other checks which ensure that _fuseIntervalEnd is already less than 32 ether and the start of the interval is less than the end.

github-actions[bot] commented 1 month ago
Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against f97907386680683d0b1fb67b6d17ee85d82c3b14

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.99%. Comparing base (8748170) to head (f979073).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sparrowDom/nativeStaking #2082 +/- ## ========================================================= Coverage 62.99% 62.99% ========================================================= Files 65 65 Lines 3243 3243 Branches 839 839 ========================================================= Hits 2043 2043 Misses 1197 1197 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.