Closed naddison36 closed 1 month ago
Warnings | |
---|---|
:warning: | :eyes: This PR needs at least 2 reviewers |
Generated by :no_entry_sign: dangerJS against f97907386680683d0b1fb67b6d17ee85d82c3b14
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.99%. Comparing base (
8748170
) to head (f979073
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Contract changes
ValidatorAccountant.setFuseInterval
Issue
The require statement in _doAccounting checks that both
_fuseIntervalStart
and_fuseIntervalEnd
are less than 32 ether and that_fuseIntervalStart < _fuseIntervalEnd
. However, the_fuseIntervalStart < 32 ether
condition is redundant as this condition is already ensured by the two other checks which ensure that_fuseIntervalEnd
is already less than 32 ether and the start of the interval is less than the end.