OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
119 stars 80 forks source link

OZ - Native Staking - N-07 Lack of Indexed Event Parameters #2083

Closed naddison36 closed 4 months ago

naddison36 commented 4 months ago

Contract changes

Issue

Throughout the codebase, several events do not have indexed parameters.

To improve the ability of off-chain services to search and filter for specific events, consider indexing event parameters.

Comment

Although bytes types can be indexed, the Waffle framework used for testing does not support it. Ideally, the pubkey parameters would be indexed so events for a specific validator can be filtered. But this breaks Waffle's event matchers.

github-actions[bot] commented 4 months ago
Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against b7ab50c3bf5062f55212e5665776ad51f4d08f54

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (sparrowDom/nativeStaking@706da2e). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sparrowDom/nativeStaking #2083 +/- ## =========================================================== Coverage ? 63.04% =========================================================== Files ? 65 Lines ? 3247 Branches ? 632 =========================================================== Hits ? 2047 Misses ? 1197 Partials ? 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openzeppelin-code[bot] commented 4 months ago

OZ - Native Staking - N-07 Lack of Indexed Event Parameters

Generated at commit: b7ab50c3bf5062f55212e5665776ad51f4d08f54

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
18
42
66
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector