OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
119 stars 80 forks source link

Lido Withdraw Strategy deployment changes #2116

Closed naddison36 closed 3 months ago

naddison36 commented 3 months ago

Code Change Checklist

To be completed before internal review begins:

Internal review:

github-actions[bot] commented 3 months ago
Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against 3e6a8695f124cc757178e1681933c4d20be02bd6

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.27%. Comparing base (bbb0b28) to head (3e6a869).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2116 +/- ## ========================================== + Coverage 61.28% 62.27% +0.98% ========================================== Files 66 66 Lines 3322 3321 -1 Branches 863 862 -1 ========================================== + Hits 2036 2068 +32 + Misses 1283 1250 -33 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openzeppelin-code[bot] commented 3 months ago

Lido Withdraw Strategy deployment changes

Generated at commit: 3e6a8695f124cc757178e1681933c4d20be02bd6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
18
42
66
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

sparrowDom commented 3 months ago

thanks for these changes @naddison36. The fork tests failing don't seem to be related to this branch