OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
119 stars 80 forks source link

Deploy 098 LidoWithdrawalStrategy #2117

Closed sparrowDom closed 3 months ago

sparrowDom commented 3 months ago

Change PRs

Contracts

Deployment script 098_lido_withdrawal_strategy

LidoWithdrawalStrategyProxy: 0x02087ea54ee7b6421089AE23E7ff6cD506f507f9 LidoWithdrawalStrategy: 0xDbCD3CbF3fb639a2DB5c7950793c5020d7780071

Governance

Proposal transaction: 0xe54380b3b4bf8d4cc505a0abacda4eb28824ac1cfd377cca96b15beeef21ff22 Proposal id: 2626764423234271308388524116226544768850357228938163129912794625401165031109

Reviewer checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.68%. Comparing base (bbb0b28) to head (e173402). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2117 +/- ## ========================================== - Coverage 61.28% 59.68% -1.61% ========================================== Files 66 66 Lines 3322 3321 -1 Branches 863 862 -1 ========================================== - Hits 2036 1982 -54 - Misses 1283 1336 +53 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

naddison36 commented 3 months ago

@sparrowDom the deployed LidoWithdrawalStrategy contract does not match master. It's missing the late changes from yesterday in PR https://github.com/OriginProtocol/origin-dollar/pull/2116

Some of the changes are insignificant but one is important as it fixed problems in claimWithdrawals. Specifically, we need to update outstandingWithdrawals without subtracting stEthDust

outstandingWithdrawals += stETHStart;
sol2uml diff 0xDbCD3CbF3fb639a2DB5c7950793c5020d7780071 .,node_modules

Screenshot 2024-07-03 at 10 19 33 AM

sparrowDom commented 3 months ago

thanks for catching this @naddison36, closing the PR, proposal cancelled