Deploy LidoWithdrawalStrategy 098 v2

sparrowDom commented 5 days ago

Change PRs

Contracts

Deployment script 098_lido_withdrawal_strategy

LidoWithdrawalStrategyProxy: 0xD9B488280d723338Dd32d56b3900f379Eb7A7aF1 LidoWithdrawalStrategy: 0x383f9eae2F012bFAd6F84e37dB6099Ee9E4C8aF7

Governance

Proposal transaction: 0x4bc2fa49cf6ffae394e3f1348990ca936f02ea54e5e36a89af2942f7c248cd58 Proposal id: 72348788472639134460868886015864856000028908615792027540418387501511877625568

Reviewer checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.24%. Comparing base (51868b3) to head (af381cb). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2118 +/- ## ========================================== - Coverage 63.05% 61.24% -1.81% ========================================== Files 66 66 Lines 3321 3321 Branches 862 648 -214 ========================================== - Hits 2094 2034 -60 - Misses 1224 1284 +60 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

naddison36 commented 5 days ago

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.
[x] Governance proposal matches the deploy script
[x] Smoke tests pass after fork test execution of the governance proposal

The fork tests are currently failing

  1) ForkTest: Aura/WETH Price Feed
       "before each" hook for "should get Aura price":
     ERROR processing /home/runner/work/origin-dollar/origin-dollar/contracts/deploy/mainnet/098_lido_withdrawal_strategy.js:
Error: Proposal state should now be "Active" but is Pending

Contract diffs to the `master` branch

sol2uml diff 0xD9B488280d723338Dd32d56b3900f379Eb7A7aF1 .,node_modules
Compared the "LidoWithdrawalStrategyProxy" contract with address 0xD9B488280d723338Dd32d56b3900f379Eb7A7aF1 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match   contracts/proxies/Proxies.sol

sol2uml diff 0x383f9eae2F012bFAd6F84e37dB6099Ee9E4C8aF7 .,node_modules
Compared the "LidoWithdrawalStrategy" contract with address 0x383f9eae2F012bFAd6F84e37dB6099Ee9E4C8aF7 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/IWETH9.sol
match   contracts/strategies/LidoWithdrawalStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/utils/InitializableERC20Detailed.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/VaultStorage.sol

shahthepro commented 4 days ago

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.
[x] Governance proposal matches the deploy script
[x] Smoke tests pass after fork test execution of the governance proposal (Buyback one is flaky at the moment, will fix it later)

naddison36 commented 4 days ago

The fork tests are now working

OriginProtocol / origin-dollar