OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it
https://originprotocol.com
MIT License
122 stars 79 forks source link

Enable pool fees when rebalancing Aerodrome AMO #2276

Closed sparrowDom closed 1 month ago

sparrowDom commented 1 month ago

Code Change Checklist

To be completed before internal review begins:

Internal review:

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal
github-actions[bot] commented 1 month ago
Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against 4c495f36fafb1d5a5e25100a315afe2dba9335fe

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (16d7435) to head (4c495f3). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...acts/strategies/aerodrome/AerodromeAMOStrategy.sol 0.00% 20 Missing :warning:
contracts/contracts/utils/AerodromeAMOQuoter.sol 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2276 +/- ## ========================================== + Coverage 52.29% 53.36% +1.06% ========================================== Files 79 79 Lines 4090 4098 +8 Branches 1079 824 -255 ========================================== + Hits 2139 2187 +48 + Misses 1948 1908 -40 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sparrowDom commented 1 month ago

@DanielVF & @shahthepro would you mind doing another pass? Aside from burning the OETHb left on the contract the main changes were a couple of fixes on the quoter contract (as described in PR description)