Fix denomination issues with implementation

OriginProtocol / origin-dollar

OUSD and OETH are stablecoins that passively accrue yield while you are holding it

https://originprotocol.com

MIT License

122 stars 79 forks source link

Fix denomination issues with implementation #2308

Closed sparrowDom closed 2 weeks ago

sparrowDom commented 2 weeks ago

This PR fixes a problem where creditBalances, creditsPerToken, alternativeCreditsPerToken are 1e27 denominated. And while using creditBalances & credits per token with 1e18 denomination will yield correct balances the issues arises when those credit balances are added to contract's global rebasingCredits

github-actions[bot] commented 2 weeks ago

	Warnings
:warning:	:eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against 694eff7e8a24fe028c27cfd5a9ab7aeeb3867932

DanielVF commented 2 weeks ago

We can close this PR, correct?

sparrowDom commented 2 weeks ago

yes closing