search

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin
MIT License
81 stars 33 forks source link

Define how throwaway accounts are to be created #509

Open cuongdo opened 6 years ago

cuongdo commented 6 years ago

To simplify deployment of contracts, we will:

  1. Deploy contracts using a "throwaway account"
  2. Set the owners of the token and marketplace contracts to a multi-sig wallet

The question is: what are the steps to create the "throwaway account"? Also, the throwaway account needs ETH to pay for the gas for the deployments. So, this process needs to include transferring enough ETH to the throwaway account. Plus, we should transfer back any ETH before we throw away the account.

cc @joshfraser

joshfraser commented 6 years ago

It's easy to create a new wallet in Metamask. I'm happy to send funds to whoever is doing the deploy.

franckc commented 6 years ago

We currently deploy all our contracts (token, marketplace, identity) using the same account because we use the truffle migrate tool.

Are we comfortable throwing away the account we use for deploying the identity contracts ? Is there any chance we would need that account for some operations on those contracts in the future ? I can't think of anything but CCing @tyleryasaka and @nick to make sure...

joshfraser commented 6 years ago

We don't actually have to throw away the keys, the point is that the ownership is going to be transferred to a mutisig wallet. The identity contacts don't have an owner, so it shouldn't matter for them.

franckc commented 6 years ago

Yes, you are right, the identity contracts don't have an owner so should not matter.