🐃 Origin.js does not pass along the listing arbitrator, offer arbitrator, or offer affiliate

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin

MIT License

81 stars 33 forks source link

🐃 Origin.js does not pass along the listing arbitrator, offer arbitrator, or offer affiliate #537

Closed DanielVF closed 6 years ago

DanielVF commented 6 years ago

Origin.js does not set the listing arbitrator, offer arbitrator, or offer affiliate in the models. This is a problem since knowing who the offer arbitrator is, is absolutely required to safely accept a offer. As it is, there's no way for the DAPP to be able to display this to the user.

cuongdo commented 6 years ago

Because listings and offers are public variables in V00_Marketplace, Solidity auto-generates public accessor methods for them. So, given a listing's index, shouldn't it be possible to access the required info?

DanielVF commented 6 years ago

Yes, I did miss that. Updated issue to be origin.js only.

DanielVF commented 6 years ago

Fixed for now in https://github.com/OriginProtocol/origin-js/pull/549