Affiliate whitelist - Githubissues

nick commented 5 years ago

First pull request? Read our guide to contributing

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[ ] Update any relevant READMEs and docs

Description:

Adds new methods addAffiliate and removeAffiliate to Marketplace contract.
Using addAffiliate with the marketplace contract address effectively disabled the whitelist such that any affiliate may be used.
To keep consistency, you can also add an IPFS hash when adding or removing an affiliate which could contain more information about the new affiliate or why an affiliate was removed.

franckc commented 5 years ago

Sorry for being late to this conversation...

If we allow affiliate to be 0x0, won't the commission get stuck in escrow forever ?

cuongdo commented 5 years ago

@franckc that's exactly what's happening right now on master. we need to have an affiliate account on all networks and pass that through when calling makeOffer. I'm adding a contract-level safeguard so that we don't allow a non-zero commission if affiliate is 0x0

nick commented 5 years ago

Closing in favor of #548

OriginProtocol / origin-js

Affiliate whitelist #544

Checklist:

Description: