Add support for private key provider to truffle config.

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin

MIT License

81 stars 33 forks source link

Add support for private key provider to truffle config. #550

Closed franckc closed 6 years ago

franckc commented 6 years ago

First pull request? Read our guide to contributing

Checklist:

[ ] Code contains relevant tests for the problem you are solving
[ ] Ensure all new and existing tests pass
[ ] Update any relevant READMEs and docs

Description:

Added support for private key provider to the truffle config. This will allow us to use a throwaway hot wallet for doing contracts deployment, by setting the PRIVATE_KEY env variable before running the truffle migrate command.

franckc commented 6 years ago

Ah interesting. Yes, this npm package does not implement a lot: https://github.com/nosuchip/truffle-privatekey-provider/blob/master/index.js#L9

Though still it seems convenient to not rewrite that code ?

wanderingstan commented 6 years ago

Agreed, .good not to rewrite that code, and it gives us similar interface as truffle-hdwallet-provider.

There's of course always a risk in having another dependency, but I feel good on this one.