Tyleryasaka/clean build script

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin

MIT License

81 stars 33 forks source link

Tyleryasaka/clean build script #590

Closed tyleryasaka closed 5 years ago

tyleryasaka commented 5 years ago

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[x] Update any relevant READMEs and docs

Description:

See linked issue below. @tomlinton does this take care of the issue for you?

Resolves #491

franckc commented 5 years ago

Thanks for cleaning this !

Please hold off on merging this until V1 is out - trying to minimize any change that could break our deployments :)

tomlinton commented 5 years ago

@tyleryasaka looks great thanks! I'll test it out with some container builds.

@franckc If we are going to be doing much more deploying it'd be good to look at merging this so I can make staging match prod with a production build of origin-js. That will save us from issues like the one yesterday where the environments differ and we only discover the problem after we publish the package to npm. I promise to test it thoroughly so it doesn't break anything. :grin:

franckc commented 5 years ago

Yes, would be good to have staging matching prod. Let's merge it on Thu or Fri after our V1 is out.... and Tom you'll be in SF so will be easy to coordinate then...

franckc commented 5 years ago

Let me submit a PR for this cleanup on monorepo...

franckc commented 5 years ago

Moved to monorepo: https://github.com/OriginProtocol/origin/pull/758

Closing this PR.