search

OriginProtocol / origin-js

We've moved to a monorepo: https://github.com/OriginProtocol/origin
MIT License
81 stars 33 forks source link

Ignore notifications that include invalid offers #592

Closed tyleryasaka closed 5 years ago

tyleryasaka commented 5 years ago

Checklist:

Description:

See linked issue below. This prevents invalid offers from causing the getNotifications method to crash.

Resolves https://github.com/OriginProtocol/origin-js/issues/558

franckc commented 5 years ago

Sweet. Thanks for working on this !

Any chance we can add a unit test for this ?

tyleryasaka commented 5 years ago

Dammit @franckc ! I knew you would say that! :unamused:

franckc commented 5 years ago

👅

tyleryasaka commented 5 years ago

Unit test ✅

franckc commented 5 years ago

Thanks for obliging me @tyleryasaka re unit tests ! You are so nice to me... :)