The 5th atttestation will be at i=4 (0-indexed). 3 65 = 195 (no problem). 4 65 = 260... This is a problem because i is a uint8; 260 > 256, therefore overflow. :grimacing:
Thanks @crazybuster for figuring this out.
We do not need to rerun migrations, but we do need to update origin-js with this fix, so that new identities that users create do not have this bug.
Checklist:
Description:
The 5th atttestation will be at i=4 (0-indexed). 3 65 = 195 (no problem). 4 65 = 260... This is a problem because i is a uint8; 260 > 256, therefore overflow. :grimacing:
Thanks @crazybuster for figuring this out.
We do not need to rerun migrations, but we do need to update origin-js with this fix, so that new identities that users create do not have this bug.
Resolves #413