Closed ice09 closed 5 years ago
tyleryasaka
commented
5 years ago Hey @ice09 . I just wanted to let you know that the contracts in this repo were just a proof of concept. They are no longer being maintained.
The up-to-date contracts live here: https://github.com/OriginProtocol/origin/tree/master/origin-js/contracts/contracts/identity
ice09
commented
5 years ago Ok, thanks for the info. However, I wanted to check some concepts against some ERC725/735 implementation and yours is slim and comprehensible. But I won't use this in production or for some other purpose. Also will close this issue, doesn't make sense if it is not maintained any more.
DanielVF
commented
5 years ago @tyleryasaka Want me throw a header comment on each of these contract files that these were proof of concept and no longer maintained?
ice09
commented
5 years ago Makes sense, as this project is still referenced by https://erc725alliance.org/ as the standard implementation (link of "code") and also in the "official" EIP: https://github.com/ethereum/EIPs/issues/725 in implementations.
tyleryasaka
commented
5 years ago @DanielVF that would be great!
DanielVF
commented
5 years ago
Since I generate Java code from Solidity with the web3j maven plugin, I realized that the ClaimAdded event is twice present in the ERC735.sol (scroll right if you don't believe me). As Java doesn't allow same parameters for methods of the same name and the events have the same parameters (even if they appear in different sequence), the generated code doesn't compile.
I am very sure that this is an error, if not, this issue can be closed (I can just remove one event on my own for my project).