search

OriginProtocol / origin

Monorepo for our developer tools and decentralized marketplace application
https://www.originprotocol.com/developers
MIT License
652 stars 196 forks source link

Google Attestation Not Supported In Mobile #2227

Open micahalcorn opened 5 years ago

micahalcorn commented 5 years ago

According to @nick, Google does not allow logins via webview. We should just add a modal indicating that it's only available on desktop unless there is a better alternative.

At Origin, we use ZenHub to manage our engineering tasks and product development. Download their browser extension and check out our open workspace at github.com/originprotocol/origin#zenhub.

tomlinton commented 5 years ago

I can modify the user agent for the WebView. This is possible on iOS, its not supported out of the box for Android but there might be a way to do it.

nick commented 5 years ago

That'd be cool 🙂

tomlinton commented 5 years ago

Thinking about this a bit more - it is against Google's policies so we might be safer just disabling it. 😞

joshfraser commented 5 years ago

Some rules are meant to be broken.

nick commented 5 years ago

Re-opening so we can add warning screens for non-Origin mobile apps (Coinbase Wallet etc)

franckc commented 5 years ago

@norbertdragan Would you be interested in looking at this issue ? Let us know if you need any clarifications...

norbertdragan commented 5 years ago

It's not entirely clear what needs to be done here. Can you please clarify @franckc?

franckc commented 5 years ago

@norbertdragan The issue is that Google verification does not work when our dapp is used via a mobile wallet such as Coinbase, imToken, Metamask, etc... It only works if the users is on a desktop browser with a wallet or the Origin Protocol mobile wallet.

So if the user attempts to do Google verification from a non-supported browser/mobile wallet, we'd like to warn them. I don't think we have any mocks for that so feel free to use your best judgement as to how the UI should look like for this :)

Don't hesitate to ask for more clarifications if needed... Thanks for working on this issue !

norbertdragan commented 5 years ago

Thanks @franckc, I think I get it now. While testing with imToken and Metamask, I noticed a bug on my Android phone in WebView and created issue #3140 for Micah's suggestion.