Add ENS support to our DApp

OriginProtocol / origin

Monorepo for our developer tools and decentralized marketplace application

https://www.originprotocol.com/developers

MIT License

652 stars 196 forks source link

Add ENS support to our DApp #239

Open joshfraser opened 6 years ago

joshfraser commented 6 years ago

We should use the ENS reverse resolver to show ENS names in the DApp whenever possible.

Apparently this is the best library for us to use: https://www.npmjs.com/package/ethereum-ens

Open questions:

Do we want to put ENS support at the DApp level or should we bake it into Origin.js?
Do we want to show an ENS name in place of an ETH address or do we want to display both?

micahalcorn commented 5 years ago

I vote for replacing raw addresses with ENS when available.

micahalcorn commented 5 years ago

It would be great to abstract this into Origin.js so that the ENS name is returned as an attribute on a user. I think it's fine for a proof-of-concept to start out at the DApp level, if necessary.

gustavoguimaraes commented 5 years ago

I would like to take on this issue. Is it still relevant given the current Q1 priorities?

micahalcorn commented 5 years ago

Just a note to say that we no longer have Origin.js as described above 😐

Any updated thoughts on this proposed feature @joshfraser @nick?

nick commented 5 years ago

I'm not sure ENS is used widely enough to bother... perhaps we can try to resolve every wallet that has interacted with our marketplace to see how many resolve? Even so, now that we're moving away from showing wallet addresses in the dapp this may not be worth the time to implement.

joshfraser commented 5 years ago

Low priority, but I think it's still worth doing at some point. Should be fairly trivial to implement and would give us some extras points within the Ethereum community.