DApp Redesign - Githubissues

Let's keep a running list here of things to fix in 𝓓𝓐𝓟𝓟𝟛 and then later move some to separate issues.

[ ] edit me ...

Coinbase Wallet Audit 7/2/19 (ranked by priority)

[x] After going through onboarding with meta transactions, I was asked to give an email address (again) instead of getting "Congratulations". I manually exited and see that my profile was created just fine.
[x] Messaging nav should replace main one and be white.
[x] A bit too much spacing to the right of the suggested categories.
[x] Opened search/browse element is not full height (as revealed by blurring the field).

To-Do

[ ] ~Kakao attestation (for example) does not appear in the "Add Attestations" screen after completing it successfully. Then after exiting and revisiting that screen, it takes the place of the email icon. Adding Twitter attestation on top of those works as expected.~
[x] When I visit a user's public profile from listing detail, for example, the navbar should be the "nested-in-a-stack" version with the back button instead of the hamburger menu, no Origin logo, etc. This should generally be true when navigating to any non-top-level route from within the DApp.
[x] When a new message is sent from a modal, the sender should be routed to the messages screen where the relevant conversation is selected.
[ ] It should be possible to close the drawers (left nav and right account) by swiping them.
[x] "Please confirm this transaction in mobile wallet" should not appear unless meta transactions fails.
[x] Navigating to /messages should default to the most recent conversation.
[ ] When I get the "Sign to publish" prompt in user activation, there is a small white line in the top right that is scrollable with the grey, translucent background.

Done

[x] When I load the nav drawer, the "x" icon (and other icons) is not quite the same size and position as the per-open hamburger icon.
[x] Nav items in the left drawer should have more vertical spacing with a larger font. We can change "Earn Origin Tokens" to "Earn Tokens" to keep it from wrapping.
[x] In the right wallet drawer, the ETH address should be pinned to the bottom.
[x] Any truncated ETH address should have the ellipses in the middle instead of the end.
[x] Let's capitalize the "b" on "Wallet Balances".
[x] Website & Airbnb attestation placeholder text should be lightened.
[x] Website attestation disclaimer needs to be revised for relevancy/accuracy.
[x] Website attestation should be hidden on mobile.
[x] LinkedIn & GitHub attestation icons are missing from Add Verifications.
[x] Attestations do not refresh after adding
[x] When editing my profile, I get the camera/library/browse dialog when I click the white space at the top. This should only happen if I click the photo.
[x] If I click my photo in the wallet drawer, click it again to edit, then click the back arrow, I get a blockchain transaction to confirm. I didn't change anything.
[x] The grey, translucent background should fade in rather than slide in fully-formed.
[x] Clicking existing email attestation icon no longer allows me to replace my email with another.
[x] Keyboard blocks the profile creation form. (Tom)
[x] When I click "Earn Origin Tokens" and get the "not eligible" screen, it overflows horizontally causing some unfortunate scroll. (Micah)
[x] Consider preventing zoom. (Micah)
[x] On the Rewards signup screen, the "Back to home" styling is wrong. (Micah)
[x] Change "Arts and Crafts" to "Art" when browsing that category. (Micah)
[x] Review avatar, name, and address should link to public profile. (Micah)
[x] Wallet balances should not be displayed if the page is loaded in Origin Marketplace. (Micah)
[x] Currency dropdown in listing creation overflows horizontally. (Micah)
[x] Anonymous ETH address overflows horizontally on listing detail. (Micah)
[x] The placeholder text in profile creation is redundant with the labels. (Micah)
[x] Search input value remains after navigating away from results. It should clear after I make a purchase, for example.
[x] DownloadApp should never be shown when the user is in our app.
[x] Search view with featured categories remains open after clicking a category icon. This causes an odd UX if I navigate backward. It seems to hide after navigating backward if I wait long enough but I don't think it should be there at all.
[x] In the right wallet drawer, the "Earn OGN" button should lead to Rewards signup if I haven't joined yet.
[x] "Get more" (OGN) in the wallet dropdown leads to a different destination than the Earn Origin Tokens in the left nav drawer.
[x] When I go back from the phone attestation form, it closes and then separately reopens the "add verifications" screen. It should act like a navigation stack where I go directly back from phone to all attestations.
[x] If I cancel the blockchain transaction that results from "Sign to publish", the modal prompt ("...will now ask you to sign...") won't go away and I'm stuck.
[x] Both nav drawers should slide open instead of just appearing.
[x] The "Earn OGN" button should cause the right drawer to close before (or while) navigating. Otherwise, it remains open when navigating backward.
[x] The container for the "browse" categories should be full-bleed with no margin so that there isn't some whitespace on the right and left when an icon is cut off in overflow.
[x] Modals dealing with in-progress blockchain transactions should not be dismissible, particularly by clicking the screen outside of the modal.

OriginProtocol / origin

DApp Redesign #2398