search

OriginProtocol / origin

Monorepo for our developer tools and decentralized marketplace application
https://www.originprotocol.com/developers
MIT License
652 stars 196 forks source link

Dapp sending relayer requests too fast #2765

Open mikeshultz opened 5 years ago

mikeshultz commented 5 years ago

The dapp is rapid-firing some requests way too quickly.

These two transactions were sent to the relayer within a 1/10th of a second of eachother and ended up landed on the same block! Same inputs, user, and proxy, so this wasn't even multiple updates by the user but the dapp firing multiple requests.

0x26647e6d590d72ebd7748963d92c0eadc2d84b43a529d54660e90e4e47c03a36 (good) 0xeb32832102007d2eacfe345e68f2ed9413141f15e02ba4179242b0c56b45a430 (revert)

The dapp should probably show some level of restraint here.

micahalcorn commented 5 years ago

~Resolved by #2766~

micahalcorn commented 5 years ago

Actually, this issue is more for the DApp side of the equation, right @mikeshultz?

mikeshultz commented 5 years ago

Yes, this issue was specifically created for the dapp. I thought you were a label guy, @micahalcorn!

micahalcorn commented 5 years ago

Yes, thanks, I was too quick and eager to close things. 😬

franckc commented 4 years ago

This may be the source of errors we see in the listener where some ProxyCreation events are fired with an address of zero. Listener logs:

[31;22m[ERROR] event-listener: Error: Invalid proxy address in ProxyCreation event: 0x0000000000000000000000000000000000000000 at ProxyEventHandler.process (/app/infra/discovery/src/listener/handler_proxy.js:49:13) at withRetrys (/app/infra/discovery/src/listener/handler.js:90:30) at withRetrys (/app/infra/discovery/src/listener/utils.js:78:20) at handleEvent (/app/infra/discovery/src/listener/handler.js:89:11) at process._tickCallback (internal/process/next_tick.js:68:7) 'will retry in 0.108 seconds, retry count 0'

This is not causing an issue for the listener. After some retries the processing of the event is skipped. As such, not worth raising the priority of this issue.