OriginProtocol / origin

Monorepo for our developer tools and decentralized marketplace application
https://www.originprotocol.com/developers
MIT License
652 stars 196 forks source link

Invalid signature. #3061

Open sentry-io[bot] opened 5 years ago

sentry-io[bot] commented 5 years ago

Sentry Issue: ORIGIN-RELAYER-4

Invalid signature.
mikeshultz commented 5 years ago

This appears to be mobile-only. If this is related to what I suspect, the transaction confirmation modal just sits there. No error is displayed to the user, and it doesn't appear that anything is sent to Sentry for origin-mobile.

CC @tomlinton, @joshfraser

tomlinton commented 5 years ago

What made you say it is mobile only? What kind of transaction was it? Sounds like you did a bit of investigation, thought it might save me some time :)

mikeshultz commented 5 years ago

I don't have evidence that it's mobile, I suppose that's just a hunch and might be wrong. But from the only reports I got, it's just been Josh and only on the mobile app.

I wonder if there's a way we can differentiate this traffic...

And now that I'm looking at the code, this could also be a nonce issue... which shouldn't really happen unless the dapp isn't waiting for the transaction to finalize. Impatient users refreshing?

DanielVF commented 5 years ago

Get me a transaction hash, and I can see exactly why it failed.

mikeshultz commented 5 years ago

Don't have the hashes but this is undoubtedly a nonce issue. From the dapp/mobile app(mostly seem to be the latter) not waiting on a tx and allowing users to submit new transactions. This and the pending transaction error are pretty much the same client-side issue.

I'm not sure what the proper resolution is because we never nailed down the user behavior, but I'm betting it's impatient users refreshing while being shown the transaction modal for an extended period of time.