Closed DanielVF closed 2 years ago
@sparrowDom Can you review as well? ty... :)
LGTM
Have not ran smoke tests as we don't have them in this repo
FYI there is also a default admin role that some of the contracts utilise (example)
#canceler role Governor -> True
t.hasRole("0xfd643c72710c63c0180259aba6b2d05451e3591a24e58b62239378085726f783", "0x3cdD07c16614059e66344a7b579DAB4f9516C0b6")
#executor role Governor -> True
t.hasRole("0xd8aa0f3194971a2a116679f7c2090f6939c8d4e01a2a8d7e41d55e5351469e63", "0x3cdD07c16614059e66344a7b579DAB4f9516C0b6")
#proposer role Governor -> True
t.hasRole("0xb09aa5aeb3702cfd50b6b62bc4532604938f21248a27a1d5ca736082b6819cc1", "0x3cdD07c16614059e66344a7b579DAB4f9516C0b6")
#timelock admin Governor -> False
t.hasRole("0x5f58e3a2316349923ce3780f8d587db2d72378aed66a8261c916544fa6846ca5", "0x3cdD07c16614059e66344a7b579DAB4f9516C0b6")
#default admin role Governor -> False
t.hasRole("0x0000000000000000000000000000000000000000000000000000000000000000", "0x3cdD07c16614059e66344a7b579DAB4f9516C0b6")
t.hasRole("0xfd643c72710c63c0180259aba6b2d05451e3591a24e58b62239378085726f783", "0x69e078EBc4631E1947F0c38Ef0357De7ED064644")
t.hasRole("0xd8aa0f3194971a2a116679f7c2090f6939c8d4e01a2a8d7e41d55e5351469e63", "0x69e078EBc4631E1947F0c38Ef0357De7ED064644")
t.hasRole("0xb09aa5aeb3702cfd50b6b62bc4532604938f21248a27a1d5ca736082b6819cc1", "0x69e078EBc4631E1947F0c38Ef0357De7ED064644")
t.hasRole("0x5f58e3a2316349923ce3780f8d587db2d72378aed66a8261c916544fa6846ca5", "0x69e078EBc4631E1947F0c38Ef0357De7ED064644")
t.hasRole("0x0000000000000000000000000000000000000000000000000000000000000000", "0x69e078EBc4631E1947F0c38Ef0357De7ED064644")
Deploy for #328 Update Governance Parameters
Contracts deployed:
Governance proposal:
Please verify that: