OriginProtocol / ousd-governance

OUSD Governance Portal and Contracts
11 stars 4 forks source link

Failed stake extensions #353

Closed micahalcorn closed 1 year ago

micahalcorn commented 2 years ago

Multiple users are reporting issues extending their OGV stakes but I've been unable to reproduce their experiences.

User 0xfdb

User 0xe5a

User 0x96f (me)

DanielVF commented 2 years ago

Link broken on first tx.

Second TX ran out of gas.

image
micahalcorn commented 2 years ago

Link broken on first tx.

Second TX ran out of gas.

Oops, fixed

micahalcorn commented 1 year ago

I think I just experienced this, although I'm not sure if it ran out of gas or something else happened.

https://etherscan.io/tx/0x0fc32a6bd7bbd29c733a147785e77c46570ede53c87bebd4609d3fadf5be182c

Ah, yes, it does appear to have run out of gas.

https://dashboard.tenderly.co/tx/mainnet/0x0fc32a6bd7bbd29c733a147785e77c46570ede53c87bebd4609d3fadf5be182c

micahalcorn commented 1 year ago

It works ✅

micahalcorn commented 1 year ago

Related PR: https://github.com/OriginProtocol/ousd-governance/pull/361

Should we calculate the gas amount on demand with a buffer or bump it to a higher hard-coded number?

Screen Shot 2023-01-20 at 7 24 00 AM
DanielVF commented 1 year ago

Here's the number to increase https://github.com/OriginProtocol/ousd-governance/blob/72a05f943c360d52312b6803d4b71ebf49c57852/client/components/vote-escrow/LockupForm.tsx#L350